Dan Kenigsberg has submitted this change and it was merged.

Change subject: custom_net_props: blacklist 'custom' for ifcfg configurator
......................................................................


custom_net_props: blacklist 'custom' for ifcfg configurator

The ifcfg configurator has a pass network options through that makes
those options that are not blacklisted reach the ifcfg files.
However these options must be textual and valid to initscripts to
be of any use. This patch blacklists custom as it is neither textual
nor valid initscripts.

Change-Id: Ifb4eba375ed64333b960c1cdb5e77bbd1c998c2d
Signed-off-by: Antoni S. Puimedon <[email protected]>
Reviewed-on: http://gerrit.ovirt.org/26655
Reviewed-by: Dan Kenigsberg <[email protected]>
---
M tests/functional/networkTests.py
M vdsm/network/configurators/ifcfg.py
2 files changed, 11 insertions(+), 4 deletions(-)

Approvals:
  Antoni Segura Puimedon: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/26655
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb4eba375ed64333b960c1cdb5e77bbd1c998c2d
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to