Michal Skrivanek has posted comments on this change. Change subject: vm: fix _dom access when QEMU is dying ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/26539/2/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4323: min_mem = int(self.conf.get('memGuaranteedSize', '0')) * 1024 Line 4324: target_mem = dev.get('target', max_mem) Line 4325: try: Line 4326: cur_mem = self._dom.info()[2] Line 4327: except Exception: > - Please do not add new "except Exception". Catch only exception that are I'm concerned about excessive err logs during migration and right after it. It is already pretty bad …with enough drives and nics you get tens of lines of errors per VM every 2s. In a follow-up patch we should address this by aggregating the stats error to a single line Line 4328: cur_mem = 0 Line 4329: return {'balloon_max': str(max_mem), Line 4330: 'balloon_cur': str(cur_mem), Line 4331: 'balloon_min': str(min_mem), -- To view, visit http://gerrit.ovirt.org/26539 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibac9e75a484b228c67d5432b71e965bdf317b89c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
