Dan Kenigsberg has posted comments on this change. Change subject: vm: fix _dom access when QEMU is dying ......................................................................
Patch Set 3: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/26539/3/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4323: try: Line 4324: cur_mem = self._dom.info()[2] Line 4325: except (AttributeError, TypeError): Line 4326: # _dom may be None (race on shutdown); Line 4327: # if info() fails, returns None A quick review of my /usr/lib64/python2.7/site-packages/libvirt.py shows that virDomain.info() can never return None - it raises libvirtError on failure. Line 4328: self._log.exception( Line 4329: 'failed to retrieve the balloon stats') Line 4330: cur_mem = 0 Line 4331: return {'balloon_max': str(max_mem), -- To view, visit http://gerrit.ovirt.org/26539 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibac9e75a484b228c67d5432b71e965bdf317b89c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
