Michal Skrivanek has posted comments on this change. Change subject: virt: graphdev: handle ticket for multiple devices ......................................................................
Patch Set 5: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/26897/5/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4253: return {'status': doneCode, 'vmList': self.status()} Line 4254: Line 4255: def setTicket(self, otp, seconds, connAct, params): Line 4256: res = {'status': doneCode} Line 4257: for graphics in _domParseStr(self._dom.XMLDesc(0)).childNodes[0]. \ we should perhaps document that we are setting the ticket for all displays…as we're also now invoking the hook multiple times so people should be aware of the change Line 4258: getElementsByTagName('graphics'): Line 4259: res = self._setTicketForGraphicDev(graphics, otp, Line 4260: seconds, connAct, params) Line 4261: if res['status']['code'] != 0: -- To view, visit http://gerrit.ovirt.org/26897 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I62f56ea47399b0d26aafce053ea1201457564b73 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Martin Polednik <mpole...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
