Frank Kobzik has posted comments on this change. Change subject: virt: graphdev: handle ticket for multiple devices ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/26897/7/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4256: return {'status': doneCode, 'vmList': self.status()} Line 4257: Line 4258: def setTicket(self, otp, seconds, connAct, params): Line 4259: res = {'status': doneCode} Line 4260: for graphics in _domParseStr(self._dom.XMLDesc(0)).childNodes[0]. \ > Maybe I'm missing something. What can go wrong? It's probably nothing. (I just thought that if you're connecting to single console it wouldn't make sense to set the ticket for the console you won't use. But implementing device agnostic ticket would break the api even more, so I think I'm fine with this solution.) Line 4261: getElementsByTagName('graphics'): Line 4262: res = self._setTicketForGraphicDev(graphics, otp, Line 4263: seconds, connAct, params) Line 4264: if res['status']['code'] != 0: -- To view, visit http://gerrit.ovirt.org/26897 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I62f56ea47399b0d26aafce053ea1201457564b73 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
