Frank Kobzik has posted comments on this change. Change subject: schema: graphdev: document the new graphics device ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/26893/3/vdsm_api/vdsmapi-schema.json File vdsm_api/vdsmapi-schema.json: Line 2526: tlsPort I'm not totally sure about using uint for port and tlsPort. There is actually a special value (-1) that tells libvirt to auto-assign port. (On the other hand we _always_ autoassign port, so the value -1 doesn't have to be sent to vdsm. But I think it is valid when engine sends vdsm create command with graphics device that has port == -1). -- To view, visit http://gerrit.ovirt.org/26893 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7e770e87349d9dbab328809b38596947618515c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
