Francesco Romani has posted comments on this change. Change subject: schema: graphdev: document the new graphics device ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/26893/3/vdsm_api/vdsmapi-schema.json File vdsm_api/vdsmapi-schema.json: Line 2509: # Additional parameters for VM graphics devices. Line 2510: # Line 2511: # @port: The port in use for unencrypted display data Line 2512: # Line 2513: # @tlsPort: #optional The port in use for encrypted display data > isn't it the place engine is taking the real port from? Engine should take them from the return value (aka VmDefinition here in the schema) and/or from getStats/getVmStats output, and I'll preserve that, but here will be overridden to libvirt auto select. Line 2514: # Line 2515: # @keyMap: #optional The keyboard layout string (eg. 'en-us') Line 2516: # Line 2517: # @disableTicketing: #optional disable security ticketing -- To view, visit http://gerrit.ovirt.org/26893 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7e770e87349d9dbab328809b38596947618515c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
