Francesco Romani has posted comments on this change. Change subject: vm: Fix guest channel symlink creation handling ......................................................................
Patch Set 2: Code-Review+1 (1 comment) Just one minor nit about the commit message. The code looks OK. http://gerrit.ovirt.org/#/c/26882/2//COMMIT_MSG Commit Message: Line 7: vm: Fix guest channel symlink creation handling Line 8: Line 9: In case of a restart of VDSM the symlinks and sockets won't get cleaned up. Line 10: Commit 4a7af02 partially fixed the issue, however it did not consider the Line 11: case of crashing a crashing VDSM. In case of a crashing or unclean stop (kill) probably something wrong here (old edit leftovers?) "of crashing a crashing" Line 12: of VDSM the symlinks are left behind and the recovery would fail. Line 13: Line 14: This patch handles these cases and adds a bit more of documentation to the Line 15: code to improve the clarity of the cases it handles. -- To view, visit http://gerrit.ovirt.org/26882 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24e5d8e7b7e338c683d4064585539444044bb77a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
