Dan Kenigsberg has submitted this change and it was merged.

Change subject: vm: Fix guest channel symlink creation handling
......................................................................


vm: Fix guest channel symlink creation handling

In case of a restart of VDSM the symlinks and sockets won't get cleaned up.
Commit 4a7af02 partially fixed the issue, however it did not consider the
case of a crashing VDSM. In case of a crashing or unclean stop (kill)
of VDSM the symlinks are left behind and the recovery would fail.

This patch handles these cases and adds a bit more of documentation to the
code to improve the clarity of the cases it handles.

Change-Id: I24e5d8e7b7e338c683d4064585539444044bb77a
Bug-Url: https://bugzilla.redhat.com/1082986
Signed-off-by: Vinzenz Feenstra <[email protected]>
Reviewed-on: http://gerrit.ovirt.org/26882
Reviewed-by: Francesco Romani <[email protected]>
Reviewed-by: Michal Skrivanek <[email protected]>
Reviewed-by: Dan Kenigsberg <[email protected]>
---
M vdsm/virt/vm.py
1 file changed, 18 insertions(+), 5 deletions(-)

Approvals:
  Vinzenz Feenstra: Verified
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Looks good to me, but someone else must approve
  Michal Skrivanek: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/26882
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I24e5d8e7b7e338c683d4064585539444044bb77a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to