Francesco Romani has uploaded a new change for review. Change subject: tests: fix read not blocksize aligned ......................................................................
tests: fix read not blocksize aligned starting with linux 3.14.1-200.fc20.x86_64 and dd (coreutils) 8.21 the direct I/O read started to fail with (message trimmed for breviry) Storage.Misc.excCmd: DEBUG: FAILED: <err> = "/usr/bin/dd: error reading '/tmp/tmp53guul': Invalid argument\n0+1 records in\n0+1 records out\n131 bytes (131 B) copied, 0.0020193 s, 64.9 kB/s\n"; <rc> = 1 Evidence suggests this is due by the fact the data to be read is not a multiple of the block size (dd default block size is 512b; ext4 is 4k). Unfortunately. I still haven't found any document which confirm this, either from the kernel or from the coreutils camp. This patch fixes this issue locally. Please note this patch addresses only tests, since I run my VDSM on older kernels. Change-Id: I7a77133e8dfa719195958228b4fc69314bab4354 Signed-off-by: Francesco Romani <[email protected]> --- M tests/miscTests.py 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/27/27127/1 diff --git a/tests/miscTests.py b/tests/miscTests.py index 69cf690..44cb2b2 100644 --- a/tests/miscTests.py +++ b/tests/miscTests.py @@ -50,6 +50,8 @@ SUDO_USER = "root" SUDO_GROUP = "root" +BLOCK_SIZE = 512 # bytes + def watchCmd(cmd, stop, cwd=None, data=None, recoveryCallback=None): ret, out, err = utils.watchCmd(cmd, stop, cwd=cwd, data=data, @@ -856,7 +858,8 @@ # create writeData = ("Trust me, I know what self-loathing is," "but to kill myself? That would put a damper on my " - "search for answers. Not at all productive.") + "search for answers. Not at all " + "productive.".zfill(BLOCK_SIZE)) # (C) Jhonen Vasquez - Johnny the Homicidal Maniac with temporaryPath(data=writeData) as path: # read -- To view, visit http://gerrit.ovirt.org/27127 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7a77133e8dfa719195958228b4fc69314bab4354 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
