Nir Soffer has posted comments on this change. Change subject: tests: fix read not blocksize aligned ......................................................................
Patch Set 2: Code-Review+1 On Fedora 19 and RHEL 6.5 this does not happen, probably some change (dd, libc, kernel) cause this issue. It smell like lower level bug. However your solution is correct and avoid trouble with this new behavior/regression, and makes sense for readFile tests. We use readFile to read files written using direct-io, so the data size is expected to be multiple of the block size (512). My comment about tmp is correct but not related to your good change. This is an global issue in our tests that has to be fixed systematically. -- To view, visit http://gerrit.ovirt.org/27127 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a77133e8dfa719195958228b4fc69314bab4354 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
