Federico Simoncelli has posted comments on this change. Change subject: core: fixing attribute error on fenceSpmStorage ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/26358/3/vdsm/storage/spbackends.py File vdsm/storage/spbackends.py: Line 337: def forceFreeSpm(self): Line 338: # DO NOT USE, STUPID, HERE ONLY FOR BC Line 339: # TODO: SCSI Fence the 'lastOwner' Line 340: self.setSpmStatus(LVER_INVALID, SPM_ID_FREE, __securityOverride=True) Line 341: self.pool.spmRole = SPM_FREE > it returns as part of the status result being checked by the engine and was We shouldn't need the change you introduced. Line 342: Line 343: @classmethod Line 344: def _getPoolMD(cls, domain): Line 345: # This might look disgusting but this makes it so that -- To view, visit http://gerrit.ovirt.org/26358 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ae4c371e2dc97686621ea16b8cef971183a6ab2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
