Dan Kenigsberg has submitted this change and it was merged. Change subject: core: fixing attribute error on fenceSpmStorage ......................................................................
core: fixing attribute error on fenceSpmStorage In change I75493d1db60e51cccd5231b516f963c970d24c99 the pool metadata operations were moved to the pool backend, while the call to invalidateMetadata in fenceSpmStorage was left as it was, leading to an attribute error. This patch fixes it by executing the operation on the pool backend object rather than on the pool, as the metadata operation are implemented only in StoragePoolDiskBackend - there's also a check for the backend type before executing it. Though it's not the nicest way for doing so, it's the pattern already used in hsm.py,therefore in the meanwhile it can be fixed the same way. Change-Id: I5ae4c371e2dc97686621ea16b8cef971183a6ab2 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1082365 Signed-off-by: Liron Aravot <lara...@redhat.com> Reviewed-on: http://gerrit.ovirt.org/26358 Reviewed-by: Allon Mureinik <amure...@redhat.com> Reviewed-by: Nir Soffer <nsof...@redhat.com> Reviewed-by: Federico Simoncelli <fsimo...@redhat.com> --- M vdsm/storage/hsm.py M vdsm/storage/spbackends.py 2 files changed, 5 insertions(+), 4 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Federico Simoncelli: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Liron Ar: Verified -- To view, visit http://gerrit.ovirt.org/26358 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ae4c371e2dc97686621ea16b8cef971183a6ab2 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
