Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsm_config: move download certificate ......................................................................
Patch Set 19: (4 comments) http://gerrit.ovirt.org/#/c/26718/19/vdsm_reg/vdsm-reg-setup.in File vdsm_reg/vdsm-reg-setup.in: Line 216: if fOK and not os.path.exists(self.engineWebCACert): Line 217: fd_tmp, file_tmp = tempfile.mkstemp() Line 218: os.close(fd_tmp) Line 219: Line 220: registration_via_https = True > you should not care via what protocol it is, and I do not understand how yo getRhevMCert() get the ssl chain, if we can't get the ssl chain we should continue as http. See my others comments below. Line 221: try: Line 222: if not deployUtil.getRhevmCert( Line 223: IP=self.vdcName, Line 224: port=self.vdcPORT, Line 229: "%s:%s", Line 230: self.vdcName, Line 231: self.vdcPORT Line 232: ) Line 233: registration_via_https = False > fOK = False If I use fOK = False here I cannot register http request as we do these days. Line 234: Line 235: if fOK and self.cfg_fprint != "None": Line 236: engine_fprint = deployUtil.generateFingerPrint(file_tmp) Line 237: if engine_fprint: Line 233: registration_via_https = False Line 234: Line 235: if fOK and self.cfg_fprint != "None": Line 236: engine_fprint = deployUtil.generateFingerPrint(file_tmp) Line 237: if engine_fprint: > it must be something, if not it is an error anyway ok Line 238: if self.cfg_fprint.upper() != engine_fprint: Line 239: logging.error( Line 240: "Fingerprint differs from Engine\n" \ Line 241: "vdsm-reg.conf fingerprint [%s]\n" \ Line 245: ) Line 246: fOK = False Line 247: sys.exit(1) Line 248: Line 249: if fOK and registration_via_https: > if fOK is enough Not enough, if it's http registration request we should not move the file. Line 250: shutil.move(file_tmp, self.engineWebCACert) Line 251: ovirtfunctions.ovirt_store_config( Line 252: self.engineWebCACert Line 253: ) -- To view, visit http://gerrit.ovirt.org/26718 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2c025eedd2be92b9418ddbe01efc02c913af2a7 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
