Alon Bar-Lev has posted comments on this change. Change subject: vdsm_config: move download certificate ......................................................................
Patch Set 20: (1 comment) http://gerrit.ovirt.org/#/c/26718/20/vdsm_reg/vdsm-reg-setup.in File vdsm_reg/vdsm-reg-setup.in: Line 241: self.cfg_fprint.upper(), Line 242: engine_fprint Line 243: ) Line 244: fOK = False Line 245: sys.exit(1) > missing here if fOK: more correctly... if fOK and download succeeded... Line 246: shutil.move(file_tmp, self.engineWebCACert) Line 247: ovirtfunctions.ovirt_store_config( Line 248: self.engineWebCACert Line 249: ) -- To view, visit http://gerrit.ovirt.org/26718 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2c025eedd2be92b9418ddbe01efc02c913af2a7 Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
