Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsm_config: move download certificate ......................................................................
Patch Set 22: (1 comment) http://gerrit.ovirt.org/#/c/26718/22/vdsm_reg/vdsm-reg-setup.in File vdsm_reg/vdsm-reg-setup.in: Line 202: else: Line 203: fOK = self.renameBridge() Line 204: logging.debug("execute: after renameBridge: %s", fOK) Line 205: Line 206: if fOK and os.path.exists(self.engineWebCACert) and \ > If engineWebCaCert exists and user provided the fingerprint and it doesn't please forget my above comment, I missed the fOK (almost sleeping in computer). Anyway, I do believe we can remove the cert in both cases since it doesn't match the fingerprint. Line 207: self.cfg_fprint != "None": Line 208: if self.cfg_fprint.upper() != \ Line 209: deployUtil.generateFingerPrint(self.engineWebCACert): Line 210: ovirtfunctions.ovirt_safe_delete_config( -- To view, visit http://gerrit.ovirt.org/26718 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2c025eedd2be92b9418ddbe01efc02c913af2a7 Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
