Dan Kenigsberg has posted comments on this change. Change subject: vdsm_config: move download certificate ......................................................................
Patch Set 24: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/26718/24/vdsm_reg/vdsm-reg-setup.in File vdsm_reg/vdsm-reg-setup.in: Line 214: "Engine Web CA Cert file exist locally and fingerprint" Line 215: " differs from Engine fingerprint!" Line 216: ) Line 217: os.unlink(self.engineWebCACert) Line 218: fOK = False I still do not understand why this case is different to the non-match to a downloaded cert. Why sys.exit(1) is used only there? Can you use a single helper function for both? Line 219: Line 220: if fOK and not os.path.exists(self.engineWebCACert): Line 221: fd_tmp, file_tmp = tempfile.mkstemp() Line 222: os.close(fd_tmp) -- To view, visit http://gerrit.ovirt.org/26718 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2c025eedd2be92b9418ddbe01efc02c913af2a7 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
