Dan Kenigsberg has posted comments on this change. Change subject: vdsm_config: move download certificate ......................................................................
Patch Set 28: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/26718/28/vdsm_reg/vdsm-reg-setup.in File vdsm_reg/vdsm-reg-setup.in: Line 245: if fOK: Line 246: if not self._compare_fingerprint(self.engineWebCACert): Line 247: try: Line 248: ovirtfunctions.ovirt_safe_delete_config( Line 249: ca_path where is ca_path defined? Line 250: ) Line 251: except: Line 252: # TODO: catch correct exception Line 253: pass Line 248: ovirtfunctions.ovirt_safe_delete_config( Line 249: ca_path Line 250: ) Line 251: except: Line 252: # TODO: catch correct exception at the very least, we must log the swallowed exception. Line 253: pass Line 254: os.unlink(ca_path) Line 255: Line 256: # -- To view, visit http://gerrit.ovirt.org/26718 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2c025eedd2be92b9418ddbe01efc02c913af2a7 Gerrit-PatchSet: 28 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
