Alon Bar-Lev has posted comments on this change. Change subject: vdsm_config: move download certificate ......................................................................
Patch Set 30: (1 comment) http://gerrit.ovirt.org/#/c/26718/30/vdsm_reg/vdsm-reg-setup.in File vdsm_reg/vdsm-reg-setup.in: Line 243: # delete it if not. Line 244: # Line 245: if fOK: Line 246: if not self._compare_fingerprint(self.engineWebCACert): Line 247: if os.path.exist(self.engineWebCACert): if we remove this try we can reduce the nesting.... if ( not self._compare_fingerprint(self.engineWebCACert) and os.path.exist(self.engineWebCACert) ): Line 248: ovirtfunctions.ovirt_safe_delete_config( Line 249: self.engineWebCACert Line 250: ) Line 251: os.unlink(self.engineWebCACert) -- To view, visit http://gerrit.ovirt.org/26718 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2c025eedd2be92b9418ddbe01efc02c913af2a7 Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
