Dan Kenigsberg has posted comments on this change. Change subject: agent: Only forward desktopLogin when the agent is responsive ......................................................................
Patch Set 2: Code-Review-1 (1 comment) Sorry, but I still do not understand the benefit of the added logic (which is inherently racy. Vdsm may think that the agent is there, but it not longer is). http://gerrit.ovirt.org/#/c/27147/2//COMMIT_MSG Commit Message: Line 14: the desktopLogin request even if the name/version tuple for the Line 15: guest agent is not present. Line 16: VDSM on the other hand knows more reliably that the guest Line 17: agent is present and forwards it based on the 'isResponsive' Line 18: information. But what is the down side of sending a login request to a non-responsive (or non-existing) agent? Line 19: Line 20: Change-Id: Ie1c65304319df949795ec0906df1343a43129641 -- To view, visit http://gerrit.ovirt.org/27147 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1c65304319df949795ec0906df1343a43129641 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
