Vinzenz Feenstra has posted comments on this change. Change subject: agent: Only forward desktopLogin when the agent is responsive ......................................................................
Patch Set 2: Actually it logs anyway. And the error message has been sent already before. (in case the guest agent is unresponsive) The thing about 'RACY' doesn't really matter, it doesn't add more racy behaviour than it used to be anyway. I just don't want to keep trying to send data to a non existent listener in that particular case. Especially not that kind of data. The only difference is, that VDSM knows better than the engine that the guest agent is there. So I moved the check from the engine to VDSM. There's no difference here anyway. -- To view, visit http://gerrit.ovirt.org/27147 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1c65304319df949795ec0906df1343a43129641 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
