Yoav Kleinberger has posted comments on this change. Change subject: core: introducing retrieveImage ......................................................................
Patch Set 3: (3 comments) http://gerrit.ovirt.org/#/c/26741/3/vdsm/BindingXMLRPC.py File vdsm/BindingXMLRPC.py: Line 130: def do_GET(self): Line 131: length = self._getIntHeader(self.HEADER_SIZE, Line 132: httplib.BAD_REQUEST) Line 133: image = self._constructImageFromRequestInfo() Line 134: startEvent = threading.Event() rename startEvent to resumeWhenHeadersSent Line 135: methodArgs = {'fileObj': self.wfile, Line 136: 'length': length} Line 137: Line 138: # Optional header Line 147: 'application/octet-stream', Line 148: self.HEADER_CONTENT_LENGTH: Line 149: length, Line 150: self.HEADER_RESULT: json_response} Line 151: self.handle_response(headers) handle_response bad name. it makes one believe that the http communication is over. I should be send_headers Line 152: startEvent.set() Line 153: self._waitForEvent(opEndEvent) Line 154: Line 155: self._performSocketOp(operation) Line 148: self.HEADER_CONTENT_LENGTH: Line 149: length, Line 150: self.HEADER_RESULT: json_response} Line 151: self.handle_response(headers) Line 152: startEvent.set() resumeWhenHeadersSent.set() Line 153: self._waitForEvent(opEndEvent) Line 154: Line 155: self._performSocketOp(operation) Line 156: -- To view, visit http://gerrit.ovirt.org/26741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2df4d3a16f39bf80281d7669ed31fd8369bada5 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Yoav Kleinberger <yklei...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
