Dan Kenigsberg has posted comments on this change. Change subject: vdsm-tool: add the cmd get-ca-issuer ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/27651/2/lib/vdsm/tool/validate_ovirt_certs.py.in File lib/vdsm/tool/validate_ovirt_certs.py.in: Line 71: cmd = [ Line 72: EX_OPENSSL, 'x509', '-in', PATH_CACERT, '-noout', '-issuer' Line 73: ] Line 74: rc, out, err = execCmd(cmd, raw=True) Line 75: if not err: It is better practice to check rc value. -- To view, visit http://gerrit.ovirt.org/27651 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70a19f54169498c53cabba0ac75e7a5611762ece Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
