Dan Kenigsberg has posted comments on this change. Change subject: vdsm-tool: add the cmd get-ca-issuer ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/27651/2//COMMIT_MSG Commit Message: Line 8: Line 9: If oVirt Node is registered via oVirt Engine currently Line 10: we don't show to users which engine the node is registered. Line 11: This patch extracts the issuer field from cacert.pem to use Line 12: the CN (commonname) data in ovirt-node-plugin-vdsm. > why in the tool?? it really sounds like something that vdsm should expose. The certificates has nothing to do with the Vdsm/Engine API. They are part of the transport, and may not exist at all (ssl=False). The chief motivation of vdsm-tool is to control configuration of vdsm on the local host. It creates self-signed certs, and validates whether cacert really certify vdsmcert. If there is a need to extract information from vdsm-internal files, vdsm-tool is the immediate suspect. The commit message, however, should explain why this informaiton has to be extracted. Line 13: Line 14: Change-Id: I70a19f54169498c53cabba0ac75e7a5611762ece Line 15: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1039267 -- To view, visit http://gerrit.ovirt.org/27651 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70a19f54169498c53cabba0ac75e7a5611762ece Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
