Vinzenz Feenstra has posted comments on this change. Change subject: virt: graphdev: support headless VM ......................................................................
Patch Set 1: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/27846/1/vdsm/API.py File vdsm/API.py: Line 251 Line 252 Line 253 Line 254 Line 255 Please leave this. See the comment for vm.py http://gerrit.ovirt.org/#/c/27846/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1345 Line 1346 Line 1347 Line 1348 Line 1349 You should rather check whether the param is present if if so that it is one of the supported ones. Please do not drop the sanitization. Even if you fall back on vnc, we should not allow invalid values. -- To view, visit http://gerrit.ovirt.org/27846 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iafeb0bebfb43c089614127d94c054175c111ce54 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
