Francesco Romani has posted comments on this change. Change subject: virt: graphdev: support headless VM ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/27846/2/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4321: graphics = _domParseStr( Line 4322: self._dom.XMLDesc(libvirt.VIR_DOMAIN_XML_SECURE)). \ Line 4323: childNodes[0].getElementsByTagName('graphics')[0] Line 4324: except IndexError: Line 4325: self.log.error('no graphics devices configured') > error swallowing is still here Done Line 4326: return Line 4327: validto = max(time.strptime(graphics.getAttribute('passwdValidTo'), Line 4328: '%Y-%m-%dT%H:%M:%S'), Line 4329: time.gmtime(time.time() + newlife)) -- To view, visit http://gerrit.ovirt.org/27846 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iafeb0bebfb43c089614127d94c054175c111ce54 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
