Adam Litke has posted comments on this change. Change subject: Adding utility methods and conf for CPU limit MOM integration ......................................................................
Patch Set 20: Code-Review-1 (1 comment) -1 only due to lack of schema documentation. http://gerrit.ovirt.org/#/c/27258/20/vdsm/API.py File vdsm/API.py: Line 709: def setCpuTuneQuota(self, quota): Line 710: v = self._cif.vmContainer.get(self._UUID) Line 711: if not v: Line 712: return errCode['noVM'] Line 713: return v.setCpuTuneQuota(quota) I don't see any updates to the schema in vdsm_api/vdsmapi-schema.json for these new APIs. Please make sure to document the commands as well as parameter and return value types. Line 714: Line 715: def setCpuTunePeriod(self, period): Line 716: v = self._cif.vmContainer.get(self._UUID) Line 717: if not v: -- To view, visit http://gerrit.ovirt.org/27258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic502d9a4a976cd76bb6042bbb51f6cd281199631 Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko <k...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: David Caro <dcaro...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Kobi Ianko <k...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
