Kobi Ianko has posted comments on this change.

Change subject: Adding utility methods and conf for CPU limit MOM integration
......................................................................


Patch Set 20:

(1 comment)

http://gerrit.ovirt.org/#/c/27258/20/vdsm/API.py
File vdsm/API.py:

Line 709:     def setCpuTuneQuota(self, quota):
Line 710:         v = self._cif.vmContainer.get(self._UUID)
Line 711:         if not v:
Line 712:             return errCode['noVM']
Line 713:         return v.setCpuTuneQuota(quota)
> I don't see any updates to the schema in vdsm_api/vdsmapi-schema.json for t
Can you add a short explanation/link to what is the schema file and how it is 
used? 10x
Line 714: 
Line 715:     def setCpuTunePeriod(self, period):
Line 716:         v = self._cif.vmContainer.get(self._UUID)
Line 717:         if not v:


-- 
To view, visit http://gerrit.ovirt.org/27258
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic502d9a4a976cd76bb6042bbb51f6cd281199631
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: David Caro <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Kobi Ianko <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to