Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: floppy: remove special 'readonly' handling ......................................................................
vm: floppy: remove special 'readonly' handling floppy devices used to have an explicit extra check on the image permissions to determine if the image had to have the 'readonly' attribute set. Engine is already sending this information, and this check is already done previously in vm.Drive.getXML() Moreover, this check is not only redundant, but it is one of the legacy remaining places vdsm can get stuck if the ISO domain becomes inaccessible when a VM is started, because no out-of-process I/O is used. To address those issues, this patch always mark the floppy image read-only, and removes the explicit additional check and all the code which was used only by it. This patch purposefully undoes what was done to fix https://bugzilla.redhat.com/show_bug.cgi?id=674357 because nowadays there is no longer use for floppy devices outside sysprep, but this is already out of direct user control. Change-Id: Ie9183104d3739f2d4a99712e7851fc3172b82621 Bug-Url: https://bugzilla.redhat.com/755528 Relates-To: https://bugzilla.redhat.com/674357 Signed-off-by: Francesco Romani <[email protected]> Reviewed-on: http://gerrit.ovirt.org/26937 Reviewed-by: Dan Kenigsberg <[email protected]> --- M lib/vdsm/utils.py M vdsm/virt/vm.py 2 files changed, 4 insertions(+), 46 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit http://gerrit.ovirt.org/26937 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie9183104d3739f2d4a99712e7851fc3172b82621 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
