Dan Kenigsberg has posted comments on this change. Change subject: vm: floppy: remove special 'readonly' handling ......................................................................
Patch Set 4: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/26937/4/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1329: if self.extSharedState == DRIVE_SHARED_TYPE.SHARED: Line 1330: diskelem.appendChildWithArgs('shareable') Line 1331: if hasattr(self, 'readonly') and utils.tobool(self.readonly): Line 1332: diskelem.appendChildWithArgs('readonly') Line 1333: elif self.device == 'floppy' and not hasattr(self, 'readonly'): Yes, your code is better. Line 1334: # floppies are used only internally for sysprep, so Line 1335: # they are readonly unless explicitely stated otherwise Line 1336: diskelem.appendChildWithArgs('readonly') Line 1337: if hasattr(self, 'serial'): -- To view, visit http://gerrit.ovirt.org/26937 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9183104d3739f2d4a99712e7851fc3172b82621 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
