Nir Soffer has posted comments on this change. Change subject: vm: simplify the releaseVm flow ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/27175/2/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4259: if self._dom: Line 4260: self._destroyVm() Line 4261: except libvirt.libvirtError as e: Line 4262: if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN: Line 4263: self.log.warning("libvirt domain not found", exc_info=True) > one branch has warn(), the other - warning(), both text says practically th The wide try-block can be handled later - lets focus on the destroy operation. Line 4264: else: Line 4265: self.log.warn("VM %s is not running", self.conf['vmId']) Line 4266: Line 4267: if not self.cif.mom: -- To view, visit http://gerrit.ovirt.org/27175 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia25794217e63dd4c755d9c141a2e941e4baa6fd3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
