Nir Soffer has posted comments on this change. Change subject: vm: simplify the releaseVm flow ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/27175/2/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4295: except libvirt.libvirtError as e: Line 4296: if e.get_error_code() == libvirt.VIR_ERR_OPERATION_FAILED: Line 4297: self.log.warn("Failed to destroy VM '%s' " Line 4298: "gracefully", self.conf['vmId']) Line 4299: self._dom.destroy() What happens if this fails - is it possible that the vm is still running after such failure? How is this failure handled in the caller, so the vm is still considered "running" in vdsm and in engine? Line 4300: Line 4301: def deleteVm(self): Line 4302: """ Line 4303: Clean VM from the system -- To view, visit http://gerrit.ovirt.org/27175 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia25794217e63dd4c755d9c141a2e941e4baa6fd3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
