Francesco Romani has posted comments on this change. Change subject: virt: Ensure not to handle no longer tacked fds in epoll ......................................................................
Patch Set 2: Code-Review+1 (2 comments) looks ok, but I'd like a bit more information. http://gerrit.ovirt.org/#/c/28179/2//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-05-28 14:53:28 +0200 Line 6: Line 7: virt: Ensure not to handle no longer tacked fds in epoll Line 8: Line 9: In some cases it is possible that events from epoll are received before the Could you please provide one example of such cases, to better understand the scenario? Line 10: socket is closed. This patch ensures that we're still tracking the fd for Line 11: which we're receiving the event. Line 12: Line 13: Change-Id: Idde0f89d2859107dd1bb697d1753709137335677 http://gerrit.ovirt.org/#/c/28179/2/vdsm/virt/vmchannels.py File vdsm/virt/vmchannels.py: Line 69: except: Line 70: self.log.exception("Exception on read callback.") Line 71: else: Line 72: self.log.debug("Received epoll event %.08X for no longer " Line 73: "tracked fd = %d", event, fileno) Is this information of some use? I mean, we can possibly do something knowing this error happened? However I'm not against keeping it, it is just for my comprehension. Line 74: Line 75: if reconnect: Line 76: self._prepare_reconnect(fileno) Line 77: -- To view, visit http://gerrit.ovirt.org/28179 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idde0f89d2859107dd1bb697d1753709137335677 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
