Francesco Romani has posted comments on this change. Change subject: virt: Ensure not to handle no longer tacked fds in epoll ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/28179/2/vdsm/virt/vmchannels.py File vdsm/virt/vmchannels.py: Line 58: self.log.debug("Received %.08X. On fd removed by epoll.", Line 59: event) Line 60: elif (event & select.EPOLLIN): Line 61: obj = self._channels.get(fileno, None) Line 62: if obj: if obj is not None: ? (I don't know if fileno == 0 is a valid fileno, however) Line 63: obj['reconnects'] = 0 Line 64: try: Line 65: if obj['read_cb'](obj['opaque']): Line 66: obj['read_time'] = time.time() -- To view, visit http://gerrit.ovirt.org/28179 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idde0f89d2859107dd1bb697d1753709137335677 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches