Alon Bar-Lev has posted comments on this change. Change subject: vdsClient: alternative ways to provide password ......................................................................
Patch Set 14: (2 comments) http://gerrit.ovirt.org/#/c/24733/14/client/vdsClient.py File client/vdsClient.py: Line 409: vmId, password, secs = tuple(args[:3]) Line 410: connAct = 'disconnect' Line 411: params = {} Line 412: auth_password = None Line 413: for arg in args[3:]: you should parseArgs() here for each as well, no? Line 414: if arg in ['disconnect', 'keep', 'fail']: Line 415: connAct = arg Line 416: elif arg.startswith('param='): Line 417: params = self._parseDriveSpec(args[4]) Line 501: Line 502: def desktopLogin(self, args): Line 503: vmId, domain, user, password = tuple(args[:4]) Line 504: auth_password = None Line 505: for arg in args[4:]: you should parseArgs() here for each as well, no? Line 506: if arg.startswith('auth='): Line 507: auth_password = getPassword(arg[len('auth='):]) Line 508: response = self.s.desktopLogin(vmId, domain, user, Line 509: auth_password or password) -- To view, visit http://gerrit.ovirt.org/24733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I363a16e6a7872ca05e19d5f520bdba90fb492374 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
