Nir Soffer has posted comments on this change. Change subject: core: introducing uploadImageToStream ......................................................................
Patch Set 12: Code-Review-1 (1 comment) The API implemented here does not agree with the one implemented in http://gerrit.ovirt.org/27997 http://gerrit.ovirt.org/#/c/26741/12/vdsm/BindingXMLRPC.py File vdsm/BindingXMLRPC.py: Line 164: self.send_header(self.HEADER_TASK_ID, response['uuid']) Line 165: else: Line 166: self.send_response(httplib.INTERNAL_SERVER_ERROR) Line 167: Line 168: self._sendResponseHeaders(response) This is inconsistent with PUT - here we get the status-code and status-message headers for both success and failure, and in PUT we get them only on error. If this info is important only on errors, please do not send it on success. If this info is important in both cases, please send it in both cases. Sending the vdsm status in the headers is also not consistent with PUT, where we send status in json format. There no reason that an error would be different for different requests. Line 169: self.end_headers() Line 170: Line 171: if success: Line 172: startEvent.set() -- To view, visit http://gerrit.ovirt.org/26741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2df4d3a16f39bf80281d7669ed31fd8369bada5 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Yoav Kleinberger <yklei...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
