Federico Simoncelli has posted comments on this change.

Change subject: core: introducing uploadImageToStream
......................................................................


Patch Set 15: Code-Review+2

(1 comment)

Neat.

http://gerrit.ovirt.org/#/c/26741/15/vdsm/BindingXMLRPC.py
File vdsm/BindingXMLRPC.py:

Line 118:             HEADER_DOMAIN = 'Storage-Domain-Id'
Line 119:             HEADER_IMAGE = 'Image-Id'
Line 120:             HEADER_VOLUME = 'Volume-Id'
Line 121:             HEADER_TASK_ID = 'Task-Id'
Line 122:             HEADER_SIZE = 'Size'
We need to get this ASAP. It has to become "Range".
Line 123:             HEADER_CONTENT_LENGTH = 'content-length'
Line 124:             HEADER_CONTENT_TYPE = 'content-type'
Line 125: 
Line 126:             class RequestException():


-- 
To view, visit http://gerrit.ovirt.org/26741
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2df4d3a16f39bf80281d7669ed31fd8369bada5
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Yoav Kleinberger <yklei...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to