Liron Ar has posted comments on this change. Change subject: core: GET requests - use Range header ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/28465/3/vdsm/BindingXMLRPC.py File vdsm/BindingXMLRPC.py: Line 261: raise self.RequestException( Line 262: httplib.BAD_REQUEST, Line 263: "not int value %r" % value) Line 264: Line 265: def _getLength(self): note: the http spec says -http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.35.2 "A server MAY ignore the Range header". so theoratically we could ignore in all those cases and just return the whole image, as we currently not support retrieval without specifying the size, i haven't implemented it like that. Line 266: value = self._getRequiredHeader(self.HEADER_RANGE, Line 267: httplib.BAD_REQUEST) Line 268: Line 269: m = re.match('^bytes=(\d*)-(\d+)$', value) -- To view, visit http://gerrit.ovirt.org/28465 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8164867347b1cf800efd2a78cc98dbc10c02ee0d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
