Liron Aravot has posted comments on this change. Change subject: core: GET requests - use Range header ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/28465/7/vdsm/BindingXMLRPC.py File vdsm/BindingXMLRPC.py: Line 265: def _getLength(self): Line 266: value = self._getRequiredHeader(self.HEADER_RANGE, Line 267: httplib.BAD_REQUEST) Line 268: Line 269: m = re.match('r^bytes=(\d*)-(\d+)$', value) Fede, please take a look on the related comments on the previous patchset..we would like your opinion on that. Line 270: if m is None: Line 271: raise self.RequestException( Line 272: httplib.BAD_REQUEST, Line 273: "range in an unsupported format: %r", value) -- To view, visit http://gerrit.ovirt.org/28465 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8164867347b1cf800efd2a78cc98dbc10c02ee0d Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
