Dan Kenigsberg has posted comments on this change. Change subject: netinfo: Report current system values for bonding options ......................................................................
Patch Set 51: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/24456/51/vdsm/network/models.py File vdsm/network/models.py: Line 239 Line 240 Line 241 Line 242 Line 243 Sorry for noticing this only now, but this is a change of functionality. Until now, we copied former options from existring ifcfg file. Now we ignore them. This change is fine, but it deserves its own patch, with a clear warning in its commit message -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 51 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
