Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: Report current system values for bonding options
......................................................................
Patch Set 52: Verified+1
Overall, the options reported match those requested.
Only in testSetupNetworksResizeBond we can see that due to bond reusing, bond0
kept miimon=150 and changed the mode from 4 to 3. I think it is fine.
Test output with added logging in assertBondExists:
NetworkTest
testAddDelBondedNetwork(kwargs=False) INFO:root:
bondopts wanted: mode=4 miimon=150, got: miimon=150 mode=4
OK
testAddDelBondedNetwork(kwargs=True) INFO:root:
bondopts wanted: mode=4 miimon=150, got: miimon=150 mode=4
OK
testAddDelNetwork(kwargs=False) OK
testAddDelNetwork(kwargs=True) OK
testAddNetworkBondWithManyVlans(kwargs=False) OK
testAddNetworkBondWithManyVlans(kwargs=True) OK
testAddNetworkManyVlans(kwargs=False) OK
testAddNetworkManyVlans(kwargs=True) OK
testAddNetworkVlan(kwargs=False) OK
testAddNetworkVlan(kwargs=True) OK
testAddNetworkVlanBond(kwargs=False) OK
testAddNetworkVlanBond(kwargs=True) OK
testAddVlanedBridgeless OK
testAddVlanedBridgeless_oneCommand OK
testAfterNetworkSetupHook OK
testBeforeNetworkSetupHook OK
testBondHwAddress(kwargs=False) OK
testBondHwAddress(kwargs=True) OK
testBrokenBridgelessNetReplacement OK
testDelNetworkBondAccumulation INFO:root:
bondopts wanted: mode=4 miimon=150, got: miimon=150 mode=4
INFO:root:
bondopts wanted: mode=4 miimon=150, got: miimon=150 mode=4
INFO:root:
bondopts wanted: mode=4 miimon=150, got: miimon=150 mode=4
OK
testDelNetworkWithMTU(kwargs=False) OK
testDelNetworkWithMTU(kwargs=True) OK
testDelWithoutAdd(kwargs=False) OK
testDelWithoutAdd(kwargs=True) OK
testDhclientLeases(kwargs='default') OK
testDhclientLeases(kwargs='local') OK
testEditWithoutAdd(kwargs=False) OK
testEditWithoutAdd(kwargs=True) OK
testFailWithInvalidBondingName(kwargs=False) OK
testFailWithInvalidBondingName(kwargs=True) OK
testFailWithInvalidBridgeName OK
testFailWithInvalidIpConfig OK
testFailWithInvalidNic(kwargs=False) OK
testFailWithInvalidNic(kwargs=True) OK
testFailWithInvalidParams(kwargs=False) OK
testFailWithInvalidParams(kwargs=True) OK
testGetRouteDeviceTo OK
testHonorBlockingDhcp OK
testIPv6ConfigNetwork FAIL
testIpLinkWrapper OK
testLegacyBonds SKIP: legacy
bonds are expected only on el6
testLowerMtuDoesNotOverride OK
testNoBridgeLeftovers OK
testQosNetwork OK
testRedefineBondedNetworkIPs OK
testRouteExists OK
testRuleExists OK
testSafeNetworkConfig(kwargs=False) OK
testSafeNetworkConfig(kwargs=True) OK
testSetupNetworksAddBadParams(bridged=False) OK
testSetupNetworksAddBadParams(bridged=True) OK
testSetupNetworksAddBondWithManyVlans(kwargs=False) INFO:root:
bondopts wanted: mode=4 miimon=150, got: miimon=150 mode=4
INFO:root:
bondopts wanted: mode=4 miimon=150, got: miimon=150 mode=4
INFO:root:
bondopts wanted: mode=4 miimon=150, got: miimon=150 mode=4
INFO:root:
bondopts wanted: mode=4 miimon=150, got: miimon=150 mode=4
INFO:root:
bondopts wanted: mode=4 miimon=150, got: miimon=150 mode=4
OK
testSetupNetworksAddBondWithManyVlans(kwargs=True) INFO:root:
bondopts wanted: mode=4 miimon=150, got: miimon=150 mode=4
INFO:root:
bondopts wanted: mode=4 miimon=150, got: miimon=150 mode=4
INFO:root:
bondopts wanted: mode=4 miimon=150, got: miimon=150 mode=4
INFO:root:
bondopts wanted: mode=4 miimon=150, got: miimon=150 mode=4
INFO:root:
bondopts wanted: mode=4 miimon=150, got: miimon=150 mode=4
OK
testSetupNetworksAddDelBondedNetwork(kwargs=False) INFO:root:
bondopts wanted: mode=2, got: mode=2
OK
testSetupNetworksAddDelBondedNetwork(kwargs=True) INFO:root:
bondopts wanted: mode=2, got: mode=2
OK
testSetupNetworksAddDelDhcp(kwargs=False) OK
testSetupNetworksAddDelDhcp(kwargs=True) OK
testSetupNetworksAddManyVlans(kwargs=False) OK
testSetupNetworksAddManyVlans(kwargs=True) OK
testSetupNetworksAddNetworkToNicAfterBondBreaking(kwargs=False)INFO:root:
bondopts wanted: mode=4 miimon=150, got: miimon=150 mode=4
OK
testSetupNetworksAddNetworkToNicAfterBondBreaking(kwargs=True)INFO:root:
bondopts wanted: mode=4 miimon=150, got: miimon=150 mode=4
OK
testSetupNetworksAddNetworkToNicAfterBondResizing(kwargs=False)INFO:root:
bondopts wanted: mode=4 miimon=150, got: miimon=150 mode=4
INFO:root:
bondopts wanted: mode=4 miimon=150, got: miimon=150 mode=4
OK
testSetupNetworksAddNetworkToNicAfterBondResizing(kwargs=True)INFO:root:
bondopts wanted: mode=4 miimon=150, got: miimon=150 mode=4
INFO:root:
bondopts wanted: mode=4 miimon=150, got: miimon=150 mode=4
OK
testSetupNetworksAddOverExistingBond(kwargs=False) INFO:root:
bondopts wanted: mode=4 miimon=150, got: miimon=150 mode=4
INFO:root:
bondopts wanted: mode=4 miimon=150, got: miimon=150 mode=4
OK
testSetupNetworksAddOverExistingBond(kwargs=True) INFO:root:
bondopts wanted: mode=4 miimon=150, got: miimon=150 mode=4
INFO:root:
bondopts wanted: mode=4 miimon=150, got: miimon=150 mode=4
OK
testSetupNetworksAddVlan(kwargs=False) OK
testSetupNetworksAddVlan(kwargs=True) SKIP: This test
is known to break until initscripts-9.03.41-1.el6 is released to fix
https://bugzilla.redhat.com/1086897
testSetupNetworksConvertVlanNetBridgeness OK
testSetupNetworksDelOneOfBondNets INFO:root:
bondopts wanted: mode=4 miimon=150, got: miimon=150 mode=4
OK
testSetupNetworksKeepNetworkOnBondAfterBondResizing(kwargs=False)INFO:root:
bondopts wanted: mode=4 miimon=150, got: miimon=150 mode=4
INFO:root:
bondopts wanted: mode=4 miimon=150, got: miimon=150 mode=4
OK
testSetupNetworksKeepNetworkOnBondAfterBondResizing(kwargs=True)INFO:root:
bondopts wanted: mode=4 miimon=150, got: miimon=150 mode=4
INFO:root:
bondopts wanted: mode=4 miimon=150, got: miimon=150 mode=4
OK
testSetupNetworksMtus(kwargs=False) OK
testSetupNetworksMtus(kwargs=True) OK
testSetupNetworksMultiMTUsOverBond(kwargs=False) INFO:root:
bondopts wanted: mode=4 miimon=150, got: miimon=150 mode=4
INFO:root:
bondopts wanted: mode=4 miimon=150, got: miimon=150 mode=4
INFO:root:
bondopts wanted: mode=4 miimon=150, got: miimon=150 mode=4
OK
testSetupNetworksMultiMTUsOverBond(kwargs=True) INFO:root:
bondopts wanted: mode=4 miimon=150, got: miimon=150 mode=4
INFO:root:
bondopts wanted: mode=4 miimon=150, got: miimon=150 mode=4
INFO:root:
bondopts wanted: mode=4 miimon=150, got: miimon=150 mode=4
OK
testSetupNetworksMultiMTUsOverNic(kwargs=False) OK
testSetupNetworksMultiMTUsOverNic(kwargs=True) OK
testSetupNetworksNetCompatibilityBondSingleBridge OK
testSetupNetworksNetCompatibilityBondSingleBridgeless OK
testSetupNetworksNetCompatibilityNicSingleBridge OK
testSetupNetworksNetCompatibilityNicSingleBridgeless OK
testSetupNetworksNicless OK
testSetupNetworksNiclessBridgeless OK
testSetupNetworksOverDhcpIface OK
testSetupNetworksResizeBond(kwargs=False) INFO:root:
bondopts wanted: mode=4 miimon=150, got: miimon=150 mode=4
INFO:root:
bondopts wanted: mode=4 miimon=150, got: miimon=150 mode=4
INFO:root:
bondopts wanted: mode=3, got: miimon=150 mode=3
OK
testSetupNetworksResizeBond(kwargs=True) INFO:root:
bondopts wanted: mode=4 miimon=150, got: miimon=150 mode=4
INFO:root:
bondopts wanted: mode=4 miimon=150, got: miimon=150 mode=4
INFO:root:
bondopts wanted: mode=3, got: miimon=150 mode=3
OK
testSetupNetworksStableBond(kwargs=False) INFO:root:
bondopts wanted: mode=3 miimon=250, got: miimon=250 mode=3
INFO:root:
bondopts wanted: mode=3 miimon=250, got: miimon=250 mode=3
INFO:root:
bondopts wanted: mode=3 miimon=250, got: miimon=250 mode=3
INFO:root:
bondopts wanted: mode=3 miimon=250, got: miimon=250 mode=3
INFO:root:
bondopts wanted: mode=4 miimon=9, got: miimon=9 mode=4
OK
testSetupNetworksStableBond(kwargs=True) INFO:root:
bondopts wanted: mode=3 miimon=250, got: miimon=250 mode=3
INFO:root:
bondopts wanted: mode=3 miimon=250, got: miimon=250 mode=3
INFO:root:
bondopts wanted: mode=3 miimon=250, got: miimon=250 mode=3
INFO:root:
bondopts wanted: mode=3 miimon=250, got: miimon=250 mode=3
INFO:root:
bondopts wanted: mode=4 miimon=9, got: miimon=9 mode=4
OK
testStaticSourceRouting(kwargs=False) OK
testStaticSourceRouting(kwargs=True) OK
testTwiceAdd(kwargs=False) OK
testTwiceAdd(kwargs=True) OK
testVolatileConfig(kwargs=False) OK
testVolatileConfig(kwargs=True) OK
======================================================================
FAIL: testIPv6ConfigNetwork (networkTests.NetworkTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/share/vdsm/tests/functional/networkTests.py", line 198, in wrapper
func(*args, **kwargs)
File "/usr/share/vdsm/tests/testValidation.py", line 114, in wrapper
return f(*args, **kwargs)
File "/usr/share/vdsm/tests/testValidation.py", line 99, in wrapper
return f(*args, **kwargs)
File "/usr/share/vdsm/tests/functional/networkTests.py", line 1768, in
testIPv6ConfigNetwork
self.vdsm_net.netinfo.networks[network]['ipv6addrs'])
File "/usr/share/vdsm/tests/testrunner.py", line 194, in assertIn
raise self.failureException(msg)
AssertionError: 'fdb3:84e5:4ff4:55e3::1/64' not found in []
----------------------------------------------------------------------
Ran 94 tests in 624.064s
FAILED (SKIP=2, failures=1)
--
To view, visit http://gerrit.ovirt.org/24456
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26
Gerrit-PatchSet: 52
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Ondřej Svoboda <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
