Francesco Romani has posted comments on this change. Change subject: LiveMerge: Sync volume chain information after live merge ......................................................................
Patch Set 6: Code-Review+1 (1 comment) I am good with Adam's answers to my comments, so +1 for me http://gerrit.ovirt.org/#/c/26636/6/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 2986: # inconsistencies. This can happen if a live merge completed while Line 2987: # vdsm was not running to catch the event. Line 2988: for drive in self._devices[DISK_DEVICES]: Line 2989: if drive['device'] == 'disk' and isVdsmImage(drive): Line 2990: self._syncVolumeChain(drive) > We need to get the domain XML (libvirt call) and parse out the backing chai Ugh, to parse the domain XML once again... Well I guess it is another necessary evil - and another good reason to resurrect http://gerrit.ovirt.org/#/c/17694/, of course in a future work. Line 2991: Line 2992: # VmStatsThread may use block devices info from libvirt. Line 2993: # So, run it after you have this info Line 2994: self._initVmStats() -- To view, visit http://gerrit.ovirt.org/26636 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib86c19077695354b45818e0186e642ad0e8bc07c Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
