Dan Kenigsberg has posted comments on this change. Change subject: LiveMerge: Sync volume chain information after live merge ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/26636/8/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 5288: Line 5289: return {'status': doneCode} Line 5290: Line 5291: def _lookupDeviceXMLByAlias(self, targetAlias): Line 5292: domXML = self._dom.XMLDesc() please use getUnderlyingVmInfo, so we do not keep a stale _lastXMLDesc Line 5293: devices = _domParseStr(domXML).childNodes[0]. \ Line 5294: getElementsByTagName('devices')[0] Line 5295: Line 5296: for deviceXML in devices.childNodes: -- To view, visit http://gerrit.ovirt.org/26636 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib86c19077695354b45818e0186e642ad0e8bc07c Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
