Nir Soffer has posted comments on this change. Change subject: vdsm: Small post-jsonrpc udpates ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/28688/1/lib/vdsm/SecureXMLRPCServer.py File lib/vdsm/SecureXMLRPCServer.py: Line 39 Line 40 Line 41 Line 42 Line 43 > It was not moved anywhere. I checked and non of the M2C examples has it and We must init M2Crypto.threading module. Of course it did not break when you tested it, threading issues need lof of concurrency and iterations to show. This should move to high level module, maybe in vdsm/vdsm - check if we are using ssl, and init M2Crypto there. This should not be hidden in some low level module. Also find the documentation of this method and add a comment why this is required, so future developer do not remove it. Line 40: Line 41: SecureXMLRPCRequestHandler = IPXMLRPCRequestHandler Line 42: Line 43: Line 44: class SecureXMLRPCServer(SimpleIPXMLRPCServer): > The class is used in kaxmlrpclib module. It is not, that module import this module, but never uses this class :-) $ git grep SecureXMLRPCServer debian/vdsm-python.install:./usr/lib/python2.7/dist-packages/vdsm/SecureXMLRPCServer.py lib/vdsm/Makefile.am: SecureXMLRPCServer.py \ lib/vdsm/SecureXMLRPCServer.py:"""SecureXMLRPCServer.py - simple XML RPC server supporting SSL.""" lib/vdsm/SecureXMLRPCServer.py:class SecureXMLRPCServer(IPXMLRPCServer): lib/vdsm/SecureXMLRPCServer.py: SecureXMLRPCServer): lib/vdsm/SecureXMLRPCServer.py: server = SecureXMLRPCServer((self.host, self.port), lib/vdsm/vdscli.py.in:from . import SecureXMLRPCServer lib/vdsm/vdscli.py.in: TransportClass=SecureXMLRPCServer.VerifyingSafeTransport): tests/sslTests.py:from vdsm import SecureXMLRPCServer tests/sslTests.py: self.server = SecureXMLRPCServer.SSLServerSocket( vdsm.spec.in:%{python_sitearch}/%{vdsm_name}/SecureXMLRPCServer.py* vdsm/kaxmlrpclib.py:from vdsm import SecureXMLRPCServer vdsm/kaxmlrpclib.py:class TcpkeepSafeTransport(SecureXMLRPCServer.VerifyingSafeTransport): vdsm/kaxmlrpclib.py:class TcpkeepHTTPSConnection(SecureXMLRPCServer.VerifyingHTTPSConnection): vdsm/kaxmlrpclib.py: SecureXMLRPCServer.VerifyingHTTPSConnection.__init__( vdsm/kaxmlrpclib.py: SecureXMLRPCServer.VerifyingHTTPSConnection.connect(self) vdsm/kaxmlrpclib.py:class TcpkeepHTTPS(SecureXMLRPCServer.VerifyingHTTPS): The only usage of this class was in the test that you just deleted bellow, and in the test that you added. Nobody use now lib/vdsm/SecureXMLRCPServer.SecureXMLRPCServer class - kill it (in a separate patch) Line 45: def __init__(self, addr, Line 46: requestHandler=IPXMLRPCRequestHandler, Line 47: logRequests=True, allow_none=False, encoding=None, Line 48: bind_and_activate=True, -- To view, visit http://gerrit.ovirt.org/28688 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4aa9021f778a2cd30ef9c19db883fac999563d1f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
