Nir Soffer has posted comments on this change.

Change subject: vdsm: Small post-jsonrpc udpates
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/28688/1/tests/secureXmlRpcServerTests.py
File tests/secureXmlRpcServerTests.py:

Line 74:     def stop(self):
Line 75:         self.vtransport.close()
Line 76: 
Line 77: 
Line 78: class XmlRpcServerTests(TestCaseBase):
> kaxmlrpclib module is using it.
Now that we agree that this class is not used, why do we need to test it?
Line 79: 
Line 80:     def testServer(self):
Line 81:         server = Server()
Line 82:         client = Client()


-- 
To view, visit http://gerrit.ovirt.org/28688
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4aa9021f778a2cd30ef9c19db883fac999563d1f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to