Antoni Segura Puimedon has posted comments on this change. Change subject: netinfo: Add 'bootproto4' to all devices ......................................................................
Patch Set 6: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/28592/6/lib/vdsm/netinfo.py File lib/vdsm/netinfo.py: Line 759: addrs[addr['label']].append(addr) Line 760: return addrs Line 761: Line 762: Line 763: def _libvirtNets2vdsm(nets, dhcp4, gateways=None, ipv6routes=None, please, make dhcp4=None and treat it like gatewas, ip routes, etc. If it is None, obtain it. (for the reason, check the usage of the method in vdsm/network/api.py Line 764: ipAddrs=None): Line 765: if gateways is None: Line 766: gateways = getRoutes() Line 767: if ipv6routes is None: -- To view, visit http://gerrit.ovirt.org/28592 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88e8a4afa7759d37b9bd5c68a18d38baecfe94a6 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
