Ondřej Svoboda has posted comments on this change. Change subject: netinfo: Add 'bootproto4' to all devices ......................................................................
Patch Set 11: Verified+1 (1 comment) Care was taken to preserve functionality; and tests passed :-) Note the comment though, it deserves its own patch. The issue mentioned is no biggie however. http://gerrit.ovirt.org/#/c/28592/11/lib/vdsm/netinfo.py File lib/vdsm/netinfo.py: Line 799: Line 800: if vdsmnets is None: Line 801: nets = networks() Line 802: d['networks'] = _libvirtNets2vdsm(nets, dhcp4, gateways, ipv6routes, Line 803: ipaddrs) Again, just not to forget: I propose to move the call to _cfgBootprotoCompat here so vdsmnets is not altered in any way. Line 804: else: Line 805: d['networks'] = vdsmnets Line 806: Line 807: for dev in (link for link in getLinks() if not link.isHidden()): -- To view, visit http://gerrit.ovirt.org/28592 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88e8a4afa7759d37b9bd5c68a18d38baecfe94a6 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
