Dan Kenigsberg has posted comments on this change. Change subject: Adding utility methods and conf for CPU limit MOM integration ......................................................................
Patch Set 61: (1 comment) http://gerrit.ovirt.org/#/c/27258/61/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 92: Line 93: METADATA_VM_TUNE_URI = 'http://ovirt.org/vm/tune/1.0' Line 94: Line 95: # A libvirt constant for undefined cpu quota Line 96: NO_CPU_QUOTA = 0 The vm module is overcomplex as it is, we should not export anything that we do not HAVE to; unit test are allowed to touch _private constants/variable. So if these are not expected to be used out of this module and its tests, please mark it as private. Line 97: Line 98: # A libvirt constant for undefined cpu period Line 99: NO_CPU_PERIOD = 0 Line 100: -- To view, visit http://gerrit.ovirt.org/27258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic502d9a4a976cd76bb6042bbb51f6cd281199631 Gerrit-PatchSet: 61 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Kobi Ianko <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
