Francesco Romani has posted comments on this change. Change subject: Adding utility methods and conf for CPU limit MOM integration ......................................................................
Patch Set 61: Code-Review-1 (1 comment) -1 because of a question. Otherwise looks OK. http://gerrit.ovirt.org/#/c/27258/61/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 312: metadataCpuLimit = self._vm._dom.metadata( Line 313: libvirt.VIR_DOMAIN_METADATA_ELEMENT, METADATA_VM_TUNE_URI, 0) Line 314: Line 315: if metadataCpuLimit: Line 316: metadataCpuLimitXML = _domParseStr(metadataCpuLimit) How big is this XML? I guess there is not any way to avoid this, there is? I just wonder if there is any other way to extract this data Line 317: nodeList = \ Line 318: metadataCpuLimitXML.getElementsByTagName('vcpulimit') Line 319: infos['vcpuLimit'] = nodeList[0].childNodes[0].data Line 320: -- To view, visit http://gerrit.ovirt.org/27258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic502d9a4a976cd76bb6042bbb51f6cd281199631 Gerrit-PatchSet: 61 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko <k...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: David Caro <dcaro...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Kobi Ianko <k...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
