Nir Soffer has posted comments on this change. Change subject: logs: improve VDSM logs human-readability ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/28869/3/vdsm/logger.conf.in File vdsm/logger.conf.in: Line 66: [formatter_none] Line 67: format: %(message)s Line 68: Line 69: [formatter_long] Line 70: format: %(asctime)s %(levelname)s %(threadName)s (%(name)s ::%(module)s in function %(funcName)s %(pathname)s:%(lineno)d): %(message)s - Replacing :: with space is a good change. - Adding "in function" is a regression - loggername::module does not make sense, now that the delimiter is space Order should be: - time - level name - logger name - same logger may have multiple threads - thread name - multiple threads may run code in same module - pathname:lineo - standard notation e.g. grep - but only if pathname is module + ".py". If it contains the full path to the file, keep module:lineo. - function name - message If you look into engine.log, you can see that items are enclosed in [] or (), which make it easier to detect visually: 2014-06-10 13:46:57,716 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.GetCapabilitiesVDSCommand] (org.ovirt.thread.pool-6-thread-5) [196f34d9] Command GetCapabilitiesVDSCommand(HostName = voodoo2, HostId = 871162b7-9200-482b-94da-97014551eea1, vds=Host[voodoo2]) execution failed. Exception: VDSNetworkException: java.net.ConnectException: Connection refused We should cosider grouping all the meta data or some parts of it, for example: timestamp level [who logged this] (where it was logged) message Translating to: timestamp levelname [loggername threadname] (module:lineno:function) message Please show us 30 seconds log from vdsm using the old and new format. The only way to evaluate this is to look at the log, not the format. Most vdsm developers are used to the current log format, and any change which is not significantly better will be hard to sell. Check also http://www.ovirt.org/Vdsm_Log_Files. If you change the log format, you will have to document both formats. Line 71: Line 72: [formatter_sysform] Line 73: format= vdsm %(name)s %(levelname)s %(message)s Line 74: datefmt= -- To view, visit http://gerrit.ovirt.org/28869 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65fcc843b4c2c6f1b0f438937a0702b80b714978 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yoav Kleinberger <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Marina Kalinin <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: Yoav Kleinberger <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
